-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53831/
-----------------------------------------------------------

(Updated Nov. 18, 2016, 6:41 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji.


Changes
-------

Added filters whenever fromResource is called for a Protos.Resource in order to 
avoid Aurora crashing. Previously only bagFromMesosResources was using the 
SUPPORTED_RESOURCE filter.

Tested by having a vagrant cluster run with an unsupported resource for an hour 
this time in order to make sure it works. End to end testing has been re-done.


Repository: aurora


Description
-------

Placed filter when creating resource bags from Mesos resources in to avoid 
trying to conver unsupported resources which leads to the scheduler crashing.


Diffs (updated)
-----

  RELEASE-NOTES.md 392496284b7f046a5dd29a5a3f175305c28a5afe 
  docs/development/design-documents.md 6bfc679c841ef1b0861758ccc12a5150f1bdb5e3 
  docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f 
  docs/features/services.md b6bfc9de550a714b4243cf033e9f3f03ae676af2 
  docs/reference/configuration.md f2a0b1873f31e91f3bf0cac6f8448e8130fae688 
  docs/reference/task-lifecycle.md 4dcb48149e156ef1927e63f5a9fa6b53b174e755 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
0510b892b67972fd15788f5debd979883c29ba6d 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
e548a09d94b1c6d550f9beec2b7120b64d576f20 
  src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
7497fb96a578cff64b6484c587e29ec464969e84 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
589288dc877d74eea1de65715fc498523be43d7f 
  src/main/python/apache/aurora/client/api/updater_util.py 
c649316edb876565c92cc90c9f030e153c008924 
  src/main/python/apache/aurora/client/config.py 
0186af52f0d7d7e3981ec59bf6a01aafee2bcfb1 
  src/main/python/apache/aurora/config/schema/base.py 
845163043b0b7b2f9e7aca14677ca9f094658551 
  src/main/python/apache/aurora/executor/aurora_executor.py 
aee5e56ae66ec7a6acbe97d94d6187fd8646ec9a 
  src/main/python/apache/aurora/executor/common/health_checker.py 
3c7c09d173c4adbd89eddaee22cffcdd8d268378 
  src/main/python/apache/aurora/executor/common/status_checker.py 
795dae2d6b661fc528d952c2315196d94127961f 
  src/main/python/apache/aurora/executor/status_manager.py 
228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
  src/test/python/apache/aurora/client/cli/test_inspect.py 
7ef682d010660c9429d94d881dfd42d94f0ce5fd 
  src/test/python/apache/aurora/client/test_config.py 
5cf68a5145ddf9478baa30453c0bcb73136fa7eb 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
da0c56ca084b65427a6122f22f251af8637772d1 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
  src/test/python/apache/aurora/executor/test_status_manager.py 
ce4679ba1aa7b42cf0115c943d84663030182d23 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
3f82165333665d127e1ace765a7dada7348a4b91 
  src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
c9dae28b83d751cfdc7c09dc2d83ac3ee4852720 
  src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 
b85ace4bc33bda9483045732024302eb0725c89f 
  src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
b3caa4186217dbf17282a5780791ce3157f4389b 
  src/test/sh/org/apache/aurora/e2e/http_example.py 
675ece85e2cf8e45f2c6e079e39b0e095075a3fa 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
9cc6cec6633ee5973d8c9faa98ae24ab10cbeca4 

Diff: https://reviews.apache.org/r/53831/diff/


Testing
-------

./build-support/jenkins/build.sh

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

End to end testing finally passed after trying it 2 times, failures seem to be 
unrelated to this patch.


Thanks,

Renan DelValle

Reply via email to