> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Lines 2 (patched) > > <https://reviews.apache.org/r/63221/diff/3/?file=1865983#file1865983line2> > > > > I don't see this dependency in package.json. If the build is green, > > that means this code path is likely untested. > > > > Also, why did you go for lodash vs deep-equal? > > Reza Motamedi wrote: > I was testing in vagrant and this works. Not sure why it works, perhaps > one of our dependencies already depends on this? > I did not have a particular reason for picking `lodash`. It seems to a > more popular module. > > I will use `deep-equal` it is already available in the dependency list.
Ah, that makes sense. But we shouldn't depend on transitive dependencies. You can use npm install --save whenever you install a dependency to take care of writing your dependencies into the package.json file. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189110 ----------------------------------------------------------- On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63221/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 12:09 a.m.) > > > Review request for Aurora, David McLaughlin and Kai Huang. > > > Repository: aurora > > > Description > ------- > > reload instance page once a neighbor item is clicked > > > Diffs > ----- > > ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a > ui/src/main/js/pages/__tests__/Instance-test.js > 2395e2e1018d19604a76eddee15f58565f988e3a > > > Diff: https://reviews.apache.org/r/63221/diff/3/ > > > Testing > ------- > > Checked in my vagrant and now it works. > > ``` > ? ./gradlew ui:lint > ? ./gradlew ui:test > ``` > > > Thanks, > > Reza Motamedi > >
