----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ -----------------------------------------------------------
(Updated Oct. 25, 2017, 9:51 p.m.) Review request for Aurora, David McLaughlin and Kai Huang. Changes ------- - Using deep-equal instead of lodash for comparing objects. Repository: aurora Description (updated) ------- # Reload instance page once a neighbor item is clicked Diffs (updated) ----- ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a Diff: https://reviews.apache.org/r/63221/diff/4/ Changes: https://reviews.apache.org/r/63221/diff/3-4/ Testing (updated) ------- Tested in vagrant tunneled to a test cluster and it works! ``` # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10] ? ./gradlew ui:lint > Task :ui:lint > apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui > eslint src/main/js plugin/ --ext .js BUILD SUCCESSFUL in 12s 3 actionable tasks: 1 executed, 2 up-to-date # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26] ? ./gradlew ui:test > Task :ui:test > apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui > jest src/ plugin/ PASS src/main/js/components/__tests__/TaskList-test.js PASS src/main/js/pages/__tests__/Job-test.js PASS src/main/js/components/__tests__/InstanceViz-test.js PASS src/main/js/pages/__tests__/Home-test.js PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js PASS src/main/js/pages/__tests__/Jobs-test.js PASS src/main/js/pages/__tests__/Updates-test.js PASS src/main/js/components/__tests__/Pagination-test.js PASS src/main/js/components/__tests__/JobHistory-test.js PASS src/main/js/components/__tests__/Diff-test.js PASS src/main/js/pages/__tests__/Update-test.js PASS src/main/js/utils/__tests__/Common-test.js PASS src/main/js/components/__tests__/ConfigDiff-test.js PASS src/main/js/components/__tests__/TaskNeighbors-test.js PASS src/main/js/components/__tests__/Tabs-test.js PASS src/main/js/components/__tests__/UpdateDiff-test.js PASS src/main/js/utils/__tests__/Update-test.js PASS src/main/js/pages/__tests__/Instance-test.js PASS src/main/js/components/__tests__/StateMachine-test.js PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js PASS src/main/js/components/__tests__/JobConfig-test.js PASS src/main/js/components/__tests__/JobList-test.js PASS src/main/js/components/__tests__/UpdateStatus-test.js PASS src/main/js/components/__tests__/Breadcrumb-test.js PASS src/main/js/components/__tests__/InstanceHistory-test.js PASS src/main/js/components/__tests__/JobStatus-test.js PASS src/main/js/utils/__tests__/Task-test.js PASS src/main/js/components/__tests__/RoleQuota-test.js PASS src/main/js/components/__tests__/UpdateList-test.js PASS src/main/js/test-utils/__tests__/Builder-test.js Test Suites: 30 passed, 30 total Tests: 134 passed, 134 total Snapshots: 0 total Time: 6.883s Ran all test suites matching /src\/|plugin\//i. BUILD SUCCESSFUL in 9s 2 actionable tasks: 1 executed, 1 up-to-date ``` Thanks, Reza Motamedi