----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37080 -----------------------------------------------------------
src/main/python/apache/aurora/client/api/scheduler_client.py <https://reviews.apache.org/r/19143/#comment68367> The broad catch below worries me a bit. Would it be feasible to have the various _connect impls (which presumably are what are raising the various types of exceptions and therefore have a better idea of what types of exceptions might be raised) be responsible for catching the appropriate exception types and re-raising as auth errors if necessary, or is there really no way of narrowing this down to only auth errors? - Joshua Cohen On March 12, 2014, 10:59 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19143/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 10:59 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-259 > https://issues.apache.org/jira/browse/aurora-259 > > > Repository: aurora > > > Description > ------- > > Catch errors thrown by authentication modules. > > Authentication modules can throw arbitrary errors - ldap exceptions, > password errors, etc, if auth fails with one of these app specific > errors, the client current dumps its cookies in a stack dump. This > change catches the error cleanly, and transforms it into a handled > authentication exception. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 > > Diff: https://reviews.apache.org/r/19143/diff/ > > > Testing > ------- > > > Thanks, > > Mark Chu-Carroll > >
