> On March 13, 2014, 2:26 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 243 > > <https://reviews.apache.org/r/19143/diff/2/?file=517784#file517784line243> > > > > The broad catch below worries me a bit. Would it be feasible to have > > the various _connect impls (which presumably are what are raising the > > various types of exceptions and therefore have a better idea of what types > > of exceptions might be raised) be responsible for catching the appropriate > > exception types and re-raising as auth errors if necessary, or is there > > really no way of narrowing this down to only auth errors?
It would be difficult. The way that some of the auth code is patched in makes it very hard to control what exceptions get raised. (I don't want to go into more detail here; discussing how twitter does authentication on the open-source jira isn't a good idea.) - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37080 ----------------------------------------------------------- On March 12, 2014, 6:59 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19143/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 6:59 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-259 > https://issues.apache.org/jira/browse/aurora-259 > > > Repository: aurora > > > Description > ------- > > Catch errors thrown by authentication modules. > > Authentication modules can throw arbitrary errors - ldap exceptions, > password errors, etc, if auth fails with one of these app specific > errors, the client current dumps its cookies in a stack dump. This > change catches the error cleanly, and transforms it into a handled > authentication exception. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 > > Diff: https://reviews.apache.org/r/19143/diff/ > > > Testing > ------- > > > Thanks, > > Mark Chu-Carroll > >
