> On Oct. 2, 2014, 2:54 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java, line > > 147 > > <https://reviews.apache.org/r/26232/diff/2/?file=710418#file710418line147> > > > > Keep the value rich as far down as you can, to mitigate accidental > > misuse: > > Amount<Long, Time> historyPruneThreshold > > Maxim Khutornenko wrote: > Disagree. I don't really like Amount -> long ->Amount -> long dance that > would require. The Amount is converted into long only once now, converted > into an absolute timestamp and passed down to SQL to compare against. > > Bill Farner wrote: > I'm actually suggesting you avoid the dance completely. Keep > Amount<Long, Time> in the settings object, and only translate it to a long > when you need a long. The only argument i can see against this is > performance, which doesn't hold here.
Ah, in that case the comment was misplaced as I was reading that you wanted to make JobUpdateStore API Amount-aware :) - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26232/#review55186 ----------------------------------------------------------- On Oct. 2, 2014, 7:40 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26232/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:40 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-743 > https://issues.apache.org/jira/browse/AURORA-743 > > > Repository: aurora > > > Description > ------- > > The pruner runs on periodic basis and trims completed updates up to the > guranteed per job retention count. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > aa45d27391b1786ca3d5e8c928045f1b6f3cf5ef > src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java > ebae58a04e8857c5f26d4b57c27dfcda9e14c82c > src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java > c3abffe575e801cebec3572cf4aceac83a238b55 > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java > 3db0114c5432a5b7d0b01d97c75494be9e3e99a3 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java > c583e085e0458835d51ebf740a3b5f01b428bb25 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 66c91644677e7176ccf53dcfcf29a6792ec398bc > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 631ab2543dadb77b7fd1cae96adc9c0bd2f94b39 > src/main/thrift/org/apache/aurora/gen/storage.thrift > 7e502450f06abb449d06af09cc59185c6a9a2963 > src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java > 011d9ec5d84c658c2b2e39bb0b3f9d20b5440cee > > src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java > 1b1160f349d64bbcd4d20103a82f3b8eb1ca75d9 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 68df0d542e41438c0844f76fc5b9ec6996a00e8d > > src/test/java/org/apache/aurora/scheduler/updater/FakeScheduledExecutor.java > e35fe23f023f5acc6666fb2270a3634c91bec657 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 7254588b55df9a12217c8ec172abc5976892497e > > Diff: https://reviews.apache.org/r/26232/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
