> On Oct. 2, 2014, 11:16 p.m., David McLaughlin wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, > > lines 468-490 > > <https://reviews.apache.org/r/26232/diff/5/?file=713015#file713015line468> > > > > It'd be nice if this didn't just blanket delete all old updates, > > especially for active jobs. There are probably a certain class of > > service/cron that are rarely touched and it would be nice to keep around > > that change history. Would it add too much complexity to try and solve this?
Well, that would require active task queries and implementation leaking outside DB layer. I'd rather not attempt anything like that until we move TaskStore into SQL. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26232/#review55272 ----------------------------------------------------------- On Oct. 2, 2014, 10:51 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26232/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 10:51 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-743 > https://issues.apache.org/jira/browse/AURORA-743 > > > Repository: aurora > > > Description > ------- > > The pruner runs on periodic basis and trims completed updates up to the > guranteed per job retention count. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > aa45d27391b1786ca3d5e8c928045f1b6f3cf5ef > src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java > ebae58a04e8857c5f26d4b57c27dfcda9e14c82c > src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java > c3abffe575e801cebec3572cf4aceac83a238b55 > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java > 3db0114c5432a5b7d0b01d97c75494be9e3e99a3 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java > c583e085e0458835d51ebf740a3b5f01b428bb25 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 66c91644677e7176ccf53dcfcf29a6792ec398bc > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 2a81a94f99f242bbe400d8428ad1f1ce38a06a86 > src/main/thrift/org/apache/aurora/gen/storage.thrift > 7e502450f06abb449d06af09cc59185c6a9a2963 > src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java > 011d9ec5d84c658c2b2e39bb0b3f9d20b5440cee > > src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java > dbf0badbfcc19f40d9b9eeec22b7024d95a02884 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 68df0d542e41438c0844f76fc5b9ec6996a00e8d > > src/test/java/org/apache/aurora/scheduler/updater/FakeScheduledExecutor.java > e35fe23f023f5acc6666fb2270a3634c91bec657 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 6758b7b56e77882c67be2e39481ff76893ad1610 > > Diff: https://reviews.apache.org/r/26232/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
