----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review60874 -----------------------------------------------------------
Ship it! src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java <https://reviews.apache.org/r/27757/#comment102284> How about fully untethering here and doing this work in `SchedulerMain`? src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java <https://reviews.apache.org/r/27757/#comment102282> remove comment src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java <https://reviews.apache.org/r/27757/#comment102286> revert src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java <https://reviews.apache.org/r/27757/#comment102287> remove - Bill Farner On Nov. 8, 2014, 12:06 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27757/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 12:06 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-920 > https://issues.apache.org/jira/browse/AURORA-920 > > > Repository: aurora > > > Description > ------- > > This attempts to kill LifecycleModule in favor of service registration. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 72d3d60c602b2cf01445f64f3be7e4ecf53008ca > src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > fef76f5069a80959eaba04f1b4b93ff3f6ba43dd > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 > src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java > 8e9a1dc10998a313ad92e365c739b74f892e82ce > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 22c666e28e03f3c1e5a1d89fda55641526b11162 > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > cd5aa17b24209b186314f431c65062d6ed9972cb > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 36706f200e245ea08afa4dd36cb3511d0a63b097 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 354844a2540dec6450724acca18c399bc6c01f44 > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java > 844a38a285f7abf917a844a7f6a4a14749aa9b57 > src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java > a7f9401f70b567002c83f4f56407b4e1d3afa5a5 > src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java > 962aff8f4fa590935773c9fe90b1a6f59bc1c51f > > src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java > 1376237efc8f109d5a57bb8bff1c05026f257418 > src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java > 662ebdceff580af0a05f9a89d50ca1c90ddc9070 > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java > 4d58240234b8e48c1f081a8ae647c54095f9dc1d > src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java > e884209fd5965e50847f14b09a43f6aba4946b7e > > Diff: https://reviews.apache.org/r/27757/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >
