----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review62011 -----------------------------------------------------------
@ReviewBot retry - Kevin Sweeney On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27757/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 12:26 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-920 > https://issues.apache.org/jira/browse/AURORA-920 > > > Repository: aurora > > > Description > ------- > > This attempts to kill LifecycleModule in favor of service registration. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 72d3d60c602b2cf01445f64f3be7e4ecf53008ca > src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 19bf162586b90329e764cacf992df37ca68b0dc0 > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 > src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java > 8e9a1dc10998a313ad92e365c739b74f892e82ce > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 22c666e28e03f3c1e5a1d89fda55641526b11162 > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > 9e8ba658144c92eea6d24725ec47a8c0710c69c9 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 36706f200e245ea08afa4dd36cb3511d0a63b097 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 354844a2540dec6450724acca18c399bc6c01f44 > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java > 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a > src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java > a7f9401f70b567002c83f4f56407b4e1d3afa5a5 > src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java > 962aff8f4fa590935773c9fe90b1a6f59bc1c51f > > src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java > 1376237efc8f109d5a57bb8bff1c05026f257418 > src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java > e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java > 4d58240234b8e48c1f081a8ae647c54095f9dc1d > src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java > 48b3d886844622288be4131dfe8f2a77f7e316e7 > > Diff: https://reviews.apache.org/r/27757/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >