> On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote: > > I think we should leave the yaml code but drop the PyYAML dependency from > > the client requirements. (And inject it into the test -- possibly one test > > with and one test without to make sure the try/except also functions > > correctly.) I feel that .yml is actually a much more natural way of > > defining the cluster list than json, because YAML supports basic templating > > in order to reduce redundancy, similar to pystachio. > > > > The way the code is currently structured, YAML will still work fine if it's > > available in the environmenet of your Aurora client, and gracefully fall > > back if not. > > > > Thoughts? > > Zameer Manji wrote: > If we are going to drop the PyYAML dependency then I think we should drop > all of the YAML related code. I agree that YAML is a much nicer format > because of the templating functionality it has but as it stands I think the > cost of supporting YAML (native code, extra compelxity in loading) is greater > than the benefits of a simpler config file. > > Joshua Cohen wrote: > I'm not sure the added complexity is worth the minor benefits provided by > YAML. Is cluster configuration really so complex that it requires templating > (and if so, could we rely on cluster administrators to work out their own > mechanism for templatizing config, puppet/chef/etc.)
I agree with Zameer and Joshua - we should avoid complexity that only benefits partially-supported features. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69269 ----------------------------------------------------------- On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30187/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 9:09 p.m.) > > > Review request for Aurora, Brian Wickman and Zameer Manji. > > > Bugs: AURORA-1029 > https://issues.apache.org/jira/browse/AURORA-1029 > > > Repository: aurora > > > Description > ------- > > Remove support for cluster metadata in YAML format. > > > Diffs > ----- > > src/main/python/apache/aurora/common/clusters.py > e55aa774b4b868f696a7de51bb016f950871dd1e > src/test/python/apache/aurora/common/BUILD > 14165b96be99b8de418f4bb8def9f27eaf29e67d > src/test/python/apache/aurora/common/test_clusters.py > 45250e609cca1149dc296b2aaf645ff2f58f8288 > > Diff: https://reviews.apache.org/r/30187/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > test_end_to_end.sh is currently broken on master, i will address that and > ensure it passes before committing this. > > > Thanks, > > Bill Farner > >
