> On Jan. 26, 2015, 12:16 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/common/clusters.py, line 42 > > <https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42> > > > > For the purposes of sheparding this review along would you consider > > moving this to another change? > > Bill Farner wrote: > Can you give more detail on the reasoning? While i generally agree with > keeping logically-different changes separate, i don't think we should be > strictly opposed to cleaning up code in the immediate vicinity of a patch.
The patch that removes the style-checker annotations around this set of files will need to be accompanied by a change to the checkstyle tool to ignore or detect these violations. IMO that's big enough for a separate patch. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69663 ----------------------------------------------------------- On Jan. 22, 2015, 1:09 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30187/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 1:09 p.m.) > > > Review request for Aurora, Brian Wickman and Zameer Manji. > > > Bugs: AURORA-1029 > https://issues.apache.org/jira/browse/AURORA-1029 > > > Repository: aurora > > > Description > ------- > > Remove support for cluster metadata in YAML format. > > > Diffs > ----- > > src/main/python/apache/aurora/common/clusters.py > e55aa774b4b868f696a7de51bb016f950871dd1e > src/test/python/apache/aurora/common/BUILD > 14165b96be99b8de418f4bb8def9f27eaf29e67d > src/test/python/apache/aurora/common/test_clusters.py > 45250e609cca1149dc296b2aaf645ff2f58f8288 > > Diff: https://reviews.apache.org/r/30187/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > test_end_to_end.sh is currently broken on master, i will address that and > ensure it passes before committing this. > > > Thanks, > > Bill Farner > >
