narendly commented on a change in pull request #381: Implement the POC work
greedy constraint based algorithm
URL: https://github.com/apache/helix/pull/381#discussion_r314180937
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java
##########
@@ -95,22 +95,22 @@ public ClusterContext getContext() {
return _bestPossibleAssignment;
}
- /**
- * Assign the given replica to the specified instance and record the
assignment in the cluster model.
- * The cluster usage information will be updated accordingly.
- *
- * @param resourceName
- * @param partitionName
- * @param state
- * @param instanceName
- */
- public void assign(String resourceName, String partitionName, String state,
String instanceName) {
- AssignableNode node = locateAssignableNode(instanceName);
- AssignableReplica replica = locateAssignableReplica(resourceName,
partitionName, state);
-
- node.assign(replica);
- _clusterContext.addPartitionToFaultZone(node.getFaultZone(), resourceName,
partitionName);
- }
+// /**
Review comment:
Did you mean to remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
