narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314180593
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/algorithm/ConstraintBasedAlgorithm.java ########## @@ -0,0 +1,109 @@ +package org.apache.helix.controller.rebalancer.waged.algorithm; + +import org.apache.helix.controller.rebalancer.waged.constraints.HardConstraint; +import org.apache.helix.controller.rebalancer.waged.constraints.SoftConstraint; +import org.apache.helix.controller.rebalancer.waged.model.AssignableNode; +import org.apache.helix.controller.rebalancer.waged.model.AssignableReplica; +import org.apache.helix.controller.rebalancer.waged.model.ClusterContext; +import org.apache.helix.controller.rebalancer.waged.model.ClusterModel; +import org.apache.helix.controller.rebalancer.waged.model.OptimalAssignment; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; + + +/** + * The algorithm is based on a given set of constraints + * - HardConstraint: Approve or deny the assignment given its condition, any assignment cannot bypass any "hard constraint" + * - SoftConstraint: Evaluate the assignment by points/rewards/scores, a higher point means a better assignment + * <p> Review comment: @i3wangyi Oh I was referring to the p? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org