kaisun2000 opened a new pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763 ### Issues - [ x ] My PR addresses the following Helix issues and references them in the PR description: Resolve #762 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: This diff added the implementation of building realm aware shared ZKClient implementation to ShareZkClientFactory. The diff intends to achieve this with minimal change and easy to reason correctness in terms of keeping the zk client session management, sync and async semantic and auto-reconnection upon session expiration intact. ### Tests - [ ] The following tests are written for this issue: To be done. - [x ] The following is the result of the "mvn test" command on the appropriate module: "mvn -pl zookeeper-api test" pass though it does not seem to invoke any real test. ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
