dasahcc commented on a change in pull request #763: SharedZKClient
URL: https://github.com/apache/helix/pull/763#discussion_r379660611
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java
##########
@@ -40,6 +40,8 @@ RealmAwareZkClient
buildZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig
* @param connectionConfig
* @return RealmAwareZkClient
*/
- RealmAwareZkClient buildZkClient(
- RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig);
+ default RealmAwareZkClient buildZkClient(
+ RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig) {
+ return buildZkClient(connectionConfig, new
RealmAwareZkClient.RealmAwareZkClientConfig());
Review comment:
Is this default impl necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
