jiajunwang commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#discussion_r396652209
########## File path: helix-core/src/main/java/org/apache/helix/PropertyKey.java ########## @@ -474,6 +474,15 @@ public PropertyKey currentState(String instanceName, String sessionId, String re } } + /** + * Get a property key associated with the root of {@link CustomizedState} of an instance + * @param instanceName + * @return {@link PropertyKey} + */ + public PropertyKey customizedStatesRoot(String instanceName) { Review comment: I would prefer to call this method customizedState**s**, and the one for the specific state customizedState(without the s) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org