jiajunwang commented on a change in pull request #851: Modify Helix generic
controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r396824077
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -424,6 +446,20 @@ public void invoke(NotificationContext changeContext)
throws Exception {
List<CurrentState> currentStates = preFetch(_propertyKey);
currentStateChangeListener.onStateChange(instanceName, currentStates,
changeContext);
+ } else if (_changeType == CUSTOMIZED_STATE_ROOT) {
+ CustomizedStateRootChangeListener customizedStateRootChangeListener =
+ (CustomizedStateRootChangeListener) _listener;
+ String instanceName =
PropertyPathConfig.getInstanceNameFromPath(_path);
+
customizedStateRootChangeListener.onCustomizedStateRootChange(instanceName,
Review comment:
If prefetch, I guess we should get all the children for types and pass to
the onCustomizedStateRootChange() method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
