himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488873812
##########
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java:
##########
@@ -221,14 +221,19 @@ public void finalize() {
close();
}
- public void addCluster(String clusterName, boolean overwritePrevious,
CloudConfig cloudConfig)
+ public void addCluster(String clusterName, boolean overwritePrevious,
CloudConfig cloudConfig) {
+ addCluster(clusterName,
Arrays.asList(BuiltInStateModelDefinitions.values()), overwritePrevious,
cloudConfig);
+ }
+
+ public void addCluster(
+ String clusterName, List<BuiltInStateModelDefinitions> stateModelDefs,
boolean overwritePrevious, CloudConfig cloudConfig)
Review Comment:
Yes, so we are creating a function here that creates the cluster loading by
selectively loading the state-model defs.
This is needed for the an optimization that we are utilizing during every
test cluster creation. We have found that loading all state-model defs
everytime takes about 500-700ms, due to invocation of ZKUtil::isClusterSetup
function
that (repeatedly) ensure all the helix cluster paths are created before
loading a state-model.
I have added as part of the java doc as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
