himanshukandwal commented on code in PR #2735: URL: https://github.com/apache/helix/pull/2735#discussion_r1488876782
########## helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java: ########## @@ -221,21 +219,15 @@ public void testMixedListener() throws Exception { } private void verifyNonbatchedListeners(final Listener listener) throws Exception { - Boolean result = TestHelper.verify(new TestHelper.Verifier() { - @Override public boolean verify() { - return (listener._instanceConfigChangedCount == _numNode) && ( - listener._idealStateChangedCount == _numResource); - } - }, 12000); + Boolean result = TestHelper.verify(() -> (listener._instanceConfigChangedCount == _numNode) + && (listener._idealStateChangedCount == _numResource), 4000); Review Comment: Yes, I have reverted this change as timeout wont matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org