Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 )
Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG@10 PS1, Line 10: IMPALA-6215 explains a race between the lib_cache > IMO, this is not an "inadvertent interaction". I'm pretty sure many users u The test that's changed was testing for an invalid symbol that was causing a backend crash when cleaning up... the interaction with some other test, while valid, is inadvertent (and difficult to diagnose). My preference is to reign in the current test with this change so that its really testing what it intends to test and to make an explicit test for the buggy interaction with 6215. Looks like we need more coverage for this type of interaction, since I agree that its likely common. -- To view, visit http://gerrit.cloudera.org:8080/8593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica3538788b1d2ab5e361261e2ade62780b838e65 Gerrit-Change-Number: 8593 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Nov 2017 19:00:59 +0000 Gerrit-HasComments: Yes
