Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8593 )

Change subject: IMPALA-6092: avoid drop/create function interactions in e2e 
tests
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

+1 assuming the new test works on all FSes.

http://gerrit.cloudera.org:8080/#/c/8593/1/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:

http://gerrit.cloudera.org:8080/#/c/8593/1/tests/query_test/test_udfs.py@422
PS1, Line 422:     check_call(["hadoop", "fs", "-put", "-f", src_udf_path, 
tgt_udf_path])
> Couple of points. This always copies from a local source and it renames to
What I meant was that "hadoop fs -put/copyFromLocal" from what I understand is 
used to put/copy stuff across file systems and I just wanted to be sure if it 
works even in local FS mode too (we had many flaky tests in local fs mode in 
the past).

To test locally,

export TARGET_FILESYSTEM="local"
export WAREHOUSE_LOCATION_PREFIX=/foo
source bin/impala-config.sh
./run-tests.py....

I think you need to have the test-snapshot loaded in the local fs too, so it 
might not run that smoothly, but you can repro the steps manually, outside of 
an e2e.



--
To view, visit http://gerrit.cloudera.org:8080/8593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica3538788b1d2ab5e361261e2ade62780b838e65
Gerrit-Change-Number: 8593
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Nov 2017 22:22:06 +0000
Gerrit-HasComments: Yes

Reply via email to