Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 )
Change subject: IMPALA-4506: Do not display "tip of the day" if --quiet is set ...................................................................... Patch Set 1: (1 comment) Thanks for the contribution! I think the code looks fine, but we can go even farther and remove the 'intro'/'welcome' entirely if --quiet is set, or at least that would be my preference. http://gerrit.cloudera.org:8080/#/c/8613/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8613/1/shell/impala_shell.py@1481 PS1, Line 1481: intro = get_welcome_string(options.verbose) Others may have a different opinion, but I don't think we should show the 'intro' or 'welcome string' at all if --quiet is set. -- To view, visit http://gerrit.cloudera.org:8080/8613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19c6d00dfbbe805ee9c525b72eb5703840e2f582 Gerrit-Change-Number: 8613 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 04:56:17 +0000 Gerrit-HasComments: Yes
