Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8613 )
Change subject: IMPALA-4506: Do not display some intro message if --quiet is set ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Thanks for the updates. I spotted something that looks wrong to me here; comment below. http://gerrit.cloudera.org:8080/#/c/8613/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8613/4/shell/impala_shell.py@1440 PS4, Line 1440: if call(['klist', '-s']) != 0: This looks wrong to me. In the old code, we always called "klist -s". Here, however, we don't call "klist -s". It looks like the point of calling "klist -s" is to exit early if there aren't credentials available, and that seems correct to preserve. -- To view, visit http://gerrit.cloudera.org:8080/8613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19c6d00dfbbe805ee9c525b72eb5703840e2f582 Gerrit-Change-Number: 8613 Gerrit-PatchSet: 4 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Nov 2017 18:35:08 +0000 Gerrit-HasComments: Yes
