Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 )
Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8439/1/be/src/rpc/rpc-mgr.h File be/src/rpc/rpc-mgr.h: http://gerrit.cloudera.org:8080/#/c/8439/1/be/src/rpc/rpc-mgr.h@183 PS1, Line 183: /// The following strings preserve the Kudu flags original values to restore in : /// Shutdown() as they will be modified by us. : string flag_save_ca_certificate_file; : string flag_save_rpc_private_key_file; : string flag_save_rpc_certificate_file; : string flag_save_rpc_private_key_password_cmd; : string flag_save_rpc_tls_ciphers; : string flag_save_rpc_tls_min_protocol; > There is no magic here :) My point is you need to trigger the validation so Ah you're right. I assumed that would have been called through some code path, but it looks like that doesn't happen. I'll try running it as a part of our Init routines and post an updated patch. -- To view, visit http://gerrit.cloudera.org:8080/8439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a14a44fdea9ab668f3714eb69fdb188bce38f5a Gerrit-Change-Number: 8439 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Nov 2017 22:17:21 +0000 Gerrit-HasComments: Yes
