Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 )
Change subject: IMPALA-4132: Use -fno-omit-frame-pointer ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8612/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8612/1/be/CMakeLists.txt@42 PS1, Line 42: # -fno-omit-frame-pointers: Keep frame pointer for functions. Produces better > From my side no such consideration was made. I didn't do any deep research into it. It's unclear to me what tooling supports that, whether it gets stripped out when binaries are stripped, etc. It may also be a good option, but I'm in favour of moving forward with the frame pointer approach since we know that it is widely supported and doesn't appear to have a significant perf impact. -- To view, visit http://gerrit.cloudera.org:8080/8612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d0d88ba015a847356ed0274fe91017b98cb941 Gerrit-Change-Number: 8612 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Nov 2017 00:08:29 +0000 Gerrit-HasComments: Yes
