Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 )
Change subject: IMPALA-4132: Use -fno-omit-frame-pointer ...................................................................... Patch Set 2: I spoke to Gabor about this a few days ago. I agree it would be good to validate it but we we didn't plan for that - the JIRA didn't have a reproduction of a bad stacktrace scenario and the comments on the JIRA were confident that it would be beneficial. We could try building a release binary, stripping it with strip --strip-debug and inducing a crash. @Lars do you have any examples of crashes from minidumps where we got a "bad" stacktrace? -- To view, visit http://gerrit.cloudera.org:8080/8612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d0d88ba015a847356ed0274fe91017b98cb941 Gerrit-Change-Number: 8612 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Dec 2017 00:18:05 +0000 Gerrit-HasComments: No
