Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 )
Change subject: IMPALA-5993: Fix the file offset in value parsing error ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8747/1/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8747/1/be/src/exec/hdfs-scanner.cc@668 PS1, Line 668: stream_->file_offset() > Yes, that was the main reason for opening the Jira. Are you going to fix th I think there are two approaches to fix: 1. Still rely on the function by reading stream incrementally 2. Track offset instead of using the function My proposal adopts the second one because I thought ahead of the full scanning was intended such as better performace. I implemented the second one on this patch set. If you think there is no reason reading the stream incremenally, let me try to fix the problem with the first one. Is there your preference? Please let me know some reasons if you prefer the second one than the first one. -- To view, visit http://gerrit.cloudera.org:8080/8747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a4ac3199ffe12fcce0bf792b3e6ce529b9af61f Gerrit-Change-Number: 8747 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Dec 2017 21:12:16 +0000 Gerrit-HasComments: Yes
