Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 )
Change subject: IMPALA-5993: Fix the file offset in value parsing error ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8747/1/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8747/1/be/src/exec/hdfs-scanner.cc@264 PS1, Line 264: // define i1 @WriteCompleteTuple(%"class.impala::HdfsScanner"* %this, : // %"class.impala::MemPool"* %pool, : // %"struct.impala::FieldLocation"* %fields, : // %"class.impala::Tuple"* %tuple, : // %"class.impala::TupleRow"* %tuple_row, : // %"class.impala::Tuple"* %template, : // i8* %error_fields, : // i8* %error_in_row, : // i64* %error_file_offsets, : // i64* %curr_file_offset) #35 { : // entry: : // %tuple_ptr = bitcast %"class.impala::Tuple"* %tuple to : // <{ %"struct.impala::StringValue", %"struct.impala::StringValue", i32, i32, i8 }>* : // call void @_ZN6impala11HdfsScanner9InitTupleEPNS_5TupleES2_.4( : // %"class.impala::HdfsScanner"* %this, %"class.impala::Tuple"* %template, : // %"class.impala::Tuple"* %tuple) : // %0 = bitcast %"class.impala::TupleRow"* %tuple_row to : // <{ %"struct.impala::StringValue", %"struct.impala::StringValue", i32, i32, i8 }>** : // %1 = getelementptr inbounds <{ %"struct.impala::StringValue", : // %"struct.impala::StringValue", i32, i32, i8 }>*, <{ %"struct.impala::StringValue", : // %"struct.impala::StringValue", i32, i32, i8 }>** %0, i32 0 : // store <{ %"struct.impala::StringValue", %"struct.impala::StringValue", i32, i32, : // i8 }>* %tuple_ptr, <{ %"struct.impala::StringValue", : // %"struct.impala::StringValue", i32, i32, i8 }>** %1 : // br label %parse : // : // parse: ; preds = %entry : // %data_ptr = getelementptr inbounds %"struct.impala::FieldLocation", : // %"struct.impala::FieldLocation"* %fields, i32 0, i32 0 : // %len_ptr = getelementptr inbounds %"struct.impala::FieldLocation", : // %"struct.impala::FieldLocation"* %fields, i32 0, i32 1 : // %slot_error_ptr = getelementptr inbounds i8, i8* %error_fields, i32 0 : // %slot_error_file_offset_ptr = getelementptr inbounds i64, i64* %error_file_offsets, : // i32 0 : // %data = load i8*, i8** %data_ptr : // %len = load i32, i32* %len_ptr : // %len_lt_zero = icmp slt i32 %len, 0 : // %ones_compliment_len = xor i32 %len, -1 : // %positive_len = add i32 %ones_compliment_len, 1 : // %select_positive_len = select i1 %len_lt_zero, i32 %positive_len, i32 %len : // %2 = call i1 @WriteSlot(<{ %"struct.impala::StringValue", : // %"struct.impala::StringValue", i32, i32, i8 }>* %tuple_ptr, i8* %data, : // i32 %select_positive_len) : // %slot_parse_error = xor i1 %2, true : // %error_in_row1 = or i1 false, %slot_parse_error : // %3 = zext i1 %slot_parse_error to i8 : // store i8 %3, i8* %slot_error_ptr : // %curr_file_offset2 = load i64, i64* %curr_file_offset : // store i64 %curr_file_offset2, i64* %slot_error_file_offset_ptr : // %4 = zext i32 %select_positive_len to i64 : // %5 = add i64 %4, 1 : // %6 = add i64 %curr_file_offset2, %5 : // store i64 %6, i64* %curr_file_offset : // > Yes, please update it. We generally try to maintain these as we come across Done -- To view, visit http://gerrit.cloudera.org:8080/8747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a4ac3199ffe12fcce0bf792b3e6ce529b9af61f Gerrit-Change-Number: 8747 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Dec 2017 00:27:57 +0000 Gerrit-HasComments: Yes
