Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 )
Change subject: IMPALA-6291: disable AVX512 codegen in LLVM ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@110 PS2, Line 110: DEFINE_string(llvm_cpu_attr_whitelist, "sse2,cx16,prfchw,bmi2,fsgsbase,popcnt,aes,smap," What is the plan for keeping this up-to-date as Intel and AMD CPUs get more and more instruction sets? http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@1663 PS2, Line 1663: result.emplace_back(attr); nit: I think this is the same as push_back, due to reference collapsing. Do you want result.emplace_back(std::move(attr)) Same for the call on line 1670, but not the on on 1673, which I think is an rvalue reference already http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@1666 PS2, Line 1666: string attr_name = attr.substr(1); nit: const string -- To view, visit http://gerrit.cloudera.org:8080/8802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a Gerrit-Change-Number: 8802 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 18:25:54 +0000 Gerrit-HasComments: Yes
