Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 )
Change subject: IMPALA-6291: disable AVX512 codegen in LLVM ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@110 PS2, Line 110: DEFINE_string(llvm_cpu_attr_whitelist, "sse2,cx16,prfchw,bmi2,fsgsbase,popcnt,aes,smap," > Isn't that just something we need to catch in code review and testing? If w May be my question wasn't quite clear. What if a user removes avx2 from the whitelist above ? When FilterContext::CodegenInsert() runs, CpuInfo::IsSupported(CpuInfo::AVX2) can still return true if the system CPU supports this AVX2 and the branch to emit IRFunction::BLOOM_FILTER_INSERT_AVX2 will still be taken. My question is whether the mismatch between the target attribute and the instruction emitted an issue or not ? -- To view, visit http://gerrit.cloudera.org:8080/8802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a Gerrit-Change-Number: 8802 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 20:23:13 +0000 Gerrit-HasComments: Yes
