Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8791 )
Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8791/1/fe/src/main/java/org/apache/impala/analysis/SortInfo.java File fe/src/main/java/org/apache/impala/analysis/SortInfo.java: http://gerrit.cloudera.org:8080/#/c/8791/1/fe/src/main/java/org/apache/impala/analysis/SortInfo.java@195 PS1, Line 195: List<Expr> substResultExprs = > Let's create a list like this: Done http://gerrit.cloudera.org:8080/#/c/8791/1/fe/src/main/java/org/apache/impala/analysis/SortInfo.java@255 PS1, Line 255: /** > Comment sounds a little cluttered and some references like "the original ex Done http://gerrit.cloudera.org:8080/#/c/8791/1/fe/src/main/java/org/apache/impala/analysis/SortInfo.java@262 PS1, Line 262: List<Expr> exprs, List<Expr> sortSlotExprs, ExprSubstitutionMap substOrderBy, > TreeNode.collect() like in L197 Done http://gerrit.cloudera.org:8080/#/c/8791/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/8791/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@287 PS1, Line 287: List<Expr> relevantRhsExprs = Lists.newArrayList(); > relevantRhsExprs Done http://gerrit.cloudera.org:8080/#/c/8791/1/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test: http://gerrit.cloudera.org:8080/#/c/8791/1/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test@391 PS1, Line 391: # IMPALA-6280: check that TupleIsNullPredicate is materialized correctly > Good catch with the clustered hint, please modify the JIRA description to m Done -- To view, visit http://gerrit.cloudera.org:8080/8791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c0ca717aa4321a5cc84edd1d5857912f8c85583 Gerrit-Change-Number: 8791 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 18:50:19 +0000 Gerrit-HasComments: Yes
