Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8791 )
Change subject: IMPALA-6280: Materialize TupleIsNullPredicate for insert sorts ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8791/2/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: http://gerrit.cloudera.org:8080/#/c/8791/2/testdata/workloads/functional-query/queries/QueryTest/insert.test@949 PS2, Line 949: # IMPALA-6280: clustered with outer join, inline view, and TupleisNullPredicate Are you sure this test is executed even without a RESULTS section? http://gerrit.cloudera.org:8080/#/c/8791/2/testdata/workloads/functional-query/queries/QueryTest/insert.test@954 PS2, Line 954: right outer join functional.alltypes t1 on t1.id = v.id let's use alltypestiny for t1 -- To view, visit http://gerrit.cloudera.org:8080/8791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c0ca717aa4321a5cc84edd1d5857912f8c85583 Gerrit-Change-Number: 8791 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 19:38:11 +0000 Gerrit-HasComments: Yes
