Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 7: (2 comments) Thank you for working on my comments. Maybe you could add some tests where the commands are not sourced from a file, but issued by ImpalaShell.send_cmd(). http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_commandline.py@585 PS7, Line 585: def run_simple_command(self, command): : run_impala_shell_cmd('-q "%s;"' % command) : : def test_commands(self): : """Testing commands which have not been tested""" : self.run_simple_command("help") Why is this test added with this change? http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/8762/7/tests/shell/test_shell_interactive.py@401 PS7, Line 401: # IMPALA-5416: Test that a command following 'source' won't be run twice. : result = run_impala_shell_interactive( : "source shell_case_sensitive.cmds;select \"second command\";") The IMPALA-5416 part is a leftover from copy-pasting test_source_file. "select \"second command\"" is also part of IMPALA-5416, it shouldn't be here. -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 7 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Dec 2017 10:51:15 +0000 Gerrit-HasComments: Yes
