Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 9: (3 comments) Thanks for your advice. http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@580 PS9, Line 580: lower() I copied the code from the super(ImpalaShell, self).onecmd() because to override the lowering the command. I don't want early modification of the given command because it might make a bug like this. http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@581 PS9, Line 581: self.orig_cmd = cmd_ In the previous patch set, the code was placed at precmd(), but this is not a proper place. For example, "source test.txt" and test.txt has "select version()". I assumed there are two calls(i.e. source and select) for precmd(), but it happened only once for source. The reason is that, do_source -> self.execute_query_list -> self.onecmd(...) directly in loop without a call of precmd onecmd can be invoked without precmd, so I would onecmd is a right place to keep the original command. http://gerrit.cloudera.org:8080/#/c/8762/8/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/8762/8/tests/shell/test_shell_interactive.py@402 PS8, Line 402: > Note that "select \"second command\";" is also unnecessary here. Thanks for your advice. Let me add some test cases and the above case is changed to more meaningful test. -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 9 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Dec 2017 12:46:10 +0000 Gerrit-HasComments: Yes
