Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 )
Change subject: IMPALA-5191: Standardize column alias behavior ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8801/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8801/5//COMMIT_MSG@14 PS5, Line 14: SELECT int_col / 2 AS x Do we have existing end-to-end tests for queries of these forms? Would be good to confirm that the frontend produces plans that are executable and correct. http://gerrit.cloudera.org:8080/#/c/8801/5/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/8801/5/fe/src/main/java/org/apache/impala/analysis/Expr.java@817 PS5, Line 817: boolean preserveRootType, boolean substituteChildren I find it a bit hard to read code calling methods with multiple boolean arguments since it's easy to get the flags mixed up at the callsite. I'm ok with this as-is, but we could consider adding public methods instead of adding flags. E.g. trySubsitute() vs trySubsituteRoot() or trySubstituteRecursive() vs trySubstituteRoot(). -- To view, visit http://gerrit.cloudera.org:8080/8801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f82483b486acf6953876cfa672b0d034f3709a8 Gerrit-Change-Number: 8801 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Dec 2017 21:50:23 +0000 Gerrit-HasComments: Yes
