Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 )
Change subject: IMPALA-5191: Standardize column alias behavior ...................................................................... Patch Set 5: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/8801/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8801/5//COMMIT_MSG@14 PS5, Line 14: SELECT int_col / 2 AS x > Do we have existing end-to-end tests for queries of these forms? Would be g Added a new file called alias.test http://gerrit.cloudera.org:8080/#/c/8801/5/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/8801/5/fe/src/main/java/org/apache/impala/analysis/Expr.java@817 PS5, Line 817: boolean preserveRootType, boolean substituteChildren > Agreed. I like trySubstituteRecursive() and trySubstituteRootOnly() I agree, I use the proposed trySubstituteRecursive() and trySubstituteRootOnly() names. They both call the private trySubstitute() method, which still has mulitple boolean flags. I didn't change the other substitute methods where substituteChildren is the only flag. -- To view, visit http://gerrit.cloudera.org:8080/8801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f82483b486acf6953876cfa672b0d034f3709a8 Gerrit-Change-Number: 8801 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 16:33:03 +0000 Gerrit-HasComments: Yes
