Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 )
Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8676/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8676/5//COMMIT_MSG@12 PS5, Line 12: rebuild > omit "query rebuild" Done http://gerrit.cloudera.org:8080/#/c/8676/5/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/8676/5/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@56 PS5, Line 56: AtStatement > argh... I was inconsistent with my suggestion and see it here now. I have S I see. I prefer Start/End. It's more intuitive. I think the query statement(e.g. INSERT ... SELECT ...) consists of two statements: INSERT statement + SELECT statement. We can specify a hint either at the begin of or at the end of INSERT statement. AtStatement/AtQuery are unclear to me. http://gerrit.cloudera.org:8080/#/c/8676/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/8676/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@310 PS5, Line 310: actualHints, String... expectedHints) { : List<String> actualHints = Lists.newArrayList(); : for (PlanHint hint: actualHints) actualHints.add > there's some shadowing here (actualHints is a parameter and local variable) I recognized the mistake and pushed a fix on the patch set#6. In the last change, the parameter name was actualPlanHints to avoid the name conflict, but let me accept your suggestion. -- To view, visit http://gerrit.cloudera.org:8080/8676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20 Gerrit-Change-Number: 8676 Gerrit-PatchSet: 5 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 01:50:47 +0000 Gerrit-HasComments: Yes
