Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 )
Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT ...................................................................... Patch Set 7: (2 comments) Thanks for the finding missing parts. http://gerrit.cloudera.org:8080/#/c/8676/7/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/8676/7/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@a475 PS7, Line 475: > What happened to this negative test? Let me revive the test. http://gerrit.cloudera.org:8080/#/c/8676/7/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@325 PS7, Line 325: } > We should also have a negative test which shows that putting hints in both Done. Sorry for the missing. It should have to be added. -- To view, visit http://gerrit.cloudera.org:8080/8676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20 Gerrit-Change-Number: 8676 Gerrit-PatchSet: 7 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Sat, 16 Dec 2017 12:53:19 +0000 Gerrit-HasComments: Yes
