Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-4664: Unexpected string conversion in Shell ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/8762/15/bin/rat_exclude_files.txt File bin/rat_exclude_files.txt: http://gerrit.cloudera.org:8080/#/c/8762/15/bin/rat_exclude_files.txt@120 PS15, Line 120: tests/shell/shell_case_sensitive.cmds : tests/shell/shell_case_sensitive2.cmds Fix for the failure: + bin/check-rat-report.py bin/rat_exclude_files.txt rat.xml UNAPPROVED: tests/shell/shell_case_sensitive.cmds UNAPPROVED: tests/shell/shell_case_sensitive2.cmds (https://jenkins.impala.io/job/rat-check-ub1604/359/consoleText) http://gerrit.cloudera.org:8080/#/c/8762/15/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/15/shell/impala_shell.py@1144 PS15, Line 1144: self.orig_cmd = "describe" Fix for the failure: E desc test_do_methods_639a0d4c.test_do_methods E ^ E Encountered: DESC E Expected: ALTER, COMPUTE, CREATE, DELETE, DESCRIBE, DROP, EXPLAIN, GRANT, INSERT, INVALIDATE, LOAD, REFRESH, REVOKE, SELECT, SET, SHOW, TRUNCATE, UPDATE, UPSERT, USE, VALUES, WITH (https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/810) -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 15 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2017 05:27:25 +0000 Gerrit-HasComments: Yes