Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 )
Change subject: IMPALA-2640: Make a given command case-sensitive ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/8762/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8762/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-2640: Make a given command case-sensitive > I think the lower-case column description is intended. Sure. The both of IMPALA-2640 and IMPALA-4664 should be resolved by this change. Now we don't need the change: https://gerrit.cloudera.org/#/c/8639/. Let me abandon it. http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/9/shell/impala_shell.py@555 PS9, Line 555: > We still need to add a line in LICENSE.txt like: Done http://gerrit.cloudera.org:8080/#/c/8762/10/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8762/10/shell/impala_shell.py@569 PS10, Line 569: do_' + cmd_.lower()) > nit: maybe you could write "This code is based on the code from the standar Thanks. It's more clear! -- To view, visit http://gerrit.cloudera.org:8080/8762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdce9781d1d97596c188691b62a141b9bd137610 Gerrit-Change-Number: 8762 Gerrit-PatchSet: 6 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Andre Araujo <ara...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 00:11:37 +0000 Gerrit-HasComments: Yes
