Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8888 )
Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8888/2/be/src/util/mem-info.cc File be/src/util/mem-info.cc: http://gerrit.cloudera.org:8080/#/c/8888/2/be/src/util/mem-info.cc@130 PS2, Line 130: " " > Sorry to keep picking on this but does boost::trim() also consider "tab" as boost:trim() *does* trim out tabs as well. That said, the data we're parsing is using spaces, and I don't think it's plausible that that will change. https://github.com/torvalds/linux/blob/master/fs/proc/meminfo.c#L69 is the relevant source code, and it's using spaces. If you think I should remove tabs as well, I can add "\t" to find_first_not_of, but I think it'll never happen. (Annoyingly, "man proc" says that there's a name, followed by a colon, followed by a long, but it doesn't specify the spacing at all.) -- To view, visit http://gerrit.cloudera.org:8080/8888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd807f869a9359d991ba515177fb2298054520e Gerrit-Change-Number: 8888 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Jan 2018 17:11:15 +0000 Gerrit-HasComments: Yes
