Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8888 )
Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8888/2/be/src/util/proc-info-test.cc File be/src/util/proc-info-test.cc: http://gerrit.cloudera.org:8080/#/c/8888/2/be/src/util/proc-info-test.cc@55 PS2, Line 55: ASSERT_GT(result.anon_huge_pages_kb, 0) Can this be zero if transparent huge page is disabled ? May be ASSERT_GE() is safer ? -- To view, visit http://gerrit.cloudera.org:8080/8888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd807f869a9359d991ba515177fb2298054520e Gerrit-Change-Number: 8888 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Jan 2018 19:24:39 +0000 Gerrit-HasComments: Yes
