Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 )
Change subject: IMPALA-4924: Enable Decimal V2 by default ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9062/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/9062/3/be/src/exprs/expr-test.cc@7618 PS3, Line 7618: TEST_F(ExprTest, DecimalOverflowCasts) { > Sorry I missed these the first time around. I think we should duplicate thi Done http://gerrit.cloudera.org:8080/#/c/9062/1/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/9062/1/tests/hs2/test_hs2.py@a443 PS1, Line 443: > Did you miss this one? Yes, I missed this one. Fixed now -- To view, visit http://gerrit.cloudera.org:8080/9062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbdd05bf986b7947f106b396017faa3a0bd87fd7 Gerrit-Change-Number: 9062 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jan 2018 06:23:50 +0000 Gerrit-HasComments: Yes
