Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 )
Change subject: IMPALA-4924: Enable Decimal V2 by default ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9062/4/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/9062/4/tests/hs2/test_hs2.py@442 PS4, Line 442: log = self.get_log("select base64decode('foo')") > what? This looks like a completely different test. Merge conflict or some The purpose of this test is to check that we get warnings through HS2 from expr valuations. The fact that we used decimal is purely coincidental. This new test provides the same logical coverage. -- To view, visit http://gerrit.cloudera.org:8080/9062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbdd05bf986b7947f106b396017faa3a0bd87fd7 Gerrit-Change-Number: 9062 Gerrit-PatchSet: 4 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jan 2018 07:05:35 +0000 Gerrit-HasComments: Yes
