Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 )
Change subject: IMPALA-6450: loosen DCHECK in EventSequence::Start() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/9155/1/be/src/util/runtime-profile-counters.h@308 PS1, Line 308: DCHECK_GE(offset_, -1); does anything bad happen when offset_ == -1? I.e. the fix of the DCHECK is fine, but do we also need to clamp offset_ to 0? -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jan 2018 00:18:17 +0000 Gerrit-HasComments: Yes
