Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 )
Change subject: IMPALA-6450: fix EventSequence::Start() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9155/2/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/9155/2/be/src/util/runtime-profile-counters.h@340 PS2, Line 340: /// 'events_'. The caller must make sure that 'timestamps' is sorted. > Should we amend this comment to mention that the function does not consider Done -- To view, visit http://gerrit.cloudera.org:8080/9155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62317149cb8428f7d29e945a538f6cc8dd45342f Gerrit-Change-Number: 9155 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2018 19:22:02 +0000 Gerrit-HasComments: Yes
