Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 )
Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc@537 PS2, Line 537: auto save_rpc_negotiation_timeout_ms = FLAGS_rpc_negotiation_timeout_ms; Should this use something like ScopedFlagSetter() in case the ASSERT below fires ? http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc@541 PS2, Line 541: tls_krpc_address Is TLS always enabled ? Seem a bit misleading to have the "tls_" prefix here and below. http://gerrit.cloudera.org:8080/#/c/9186/2/be/src/rpc/rpc-mgr-test.cc@551 PS2, Line 551: secondary_rpc_mgr.Shutdown(); Just wondering if it'll be a problem if ASSERT() above gets triggered. Will we exit without calling Shutdown() here ? http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9186/1/be/src/rpc/rpc-mgr.cc@84 PS1, Line 84: bld.set_rpc_negotiation_timeout_ms(FLAGS_rpc_negotiation_timeout_ms); > The min number of threads is 0 by default. What that means is that there wo Makes sense. -- To view, visit http://gerrit.cloudera.org:8080/9186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I108d700e7eac04b678e21a3a920aac81ba8eede5 Gerrit-Change-Number: 9186 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2018 07:42:34 +0000 Gerrit-HasComments: Yes
