Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9186 )
Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ...................................................................... IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC With the fix for KUDU-2228, the FLAGS_rpc_negotiation_timeout_ms was retired in KRPC. This patch introduces a flag to be able to configure that from the Impala side (FLAGS_rpc_negotiation_timeout_ms). It also introduces a flag to configure the negotiation thread count (FLAGS_rpc_negotiation_thread_count). Added a test to verify that setting FLAGS_rpc_negotiation_timeout_ms to 0 causes negotiation failures. We unfortunately can't write a test to check the same for FLAGS_rpc_negotiation_thread_count due to DCHECKS present in the code. Change-Id: I108d700e7eac04b678e21a3a920aac81ba8eede5 Reviewed-on: http://gerrit.cloudera.org:8080/9186 Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/rpc/rpc-mgr-test.cc M be/src/rpc/rpc-mgr.cc 2 files changed, 28 insertions(+), 0 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I108d700e7eac04b678e21a3a920aac81ba8eede5 Gerrit-Change-Number: 9186 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>