Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9420 )
Change subject: IMPALA-3866 Improve error reporting for scratch write errors ...................................................................... IMPALA-3866 Improve error reporting for scratch write errors The error messages coming from DiskIoMgr::Write() are anhanced by this change. A mapping is introduced between the errno set by open(), fdopen(), fseek(), fwrite() or fclose() low level function and an error message for displaying purposes. Once any of these functions fail than the returned error message is taken from this mapping. In addition there were two functions, NewFile() and FileAllocateSpace() that always returned Status::OK(). I made them void and removed the status checks from the call sites. For testing purposes a fault injection mechanism is introduced to simulate the cases when the above mentioned funtions fail. Change-Id: I5aa7b424209b1a5ef8dc7d04c5ba58788e91aad7 --- M be/src/runtime/io/CMakeLists.txt M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/disk-io-mgr.h A be/src/runtime/io/errno-to-error-status-converter.cc A be/src/runtime/io/errno-to-error-status-converter.h M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h 10 files changed, 322 insertions(+), 74 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/9420/2 -- To view, visit http://gerrit.cloudera.org:8080/9420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5aa7b424209b1a5ef8dc7d04c5ba58788e91aad7 Gerrit-Change-Number: 9420 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com>
