Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 )
Change subject: IMPALA-3866 Improve error reporting for scratch write errors ...................................................................... Patch Set 2: (5 comments) I took a quick pass to understand it at a high level. Left a few comments but I think the approach makes sense. I'll let Attila finish the review before taking another look. http://gerrit.cloudera.org:8080/#/c/9420/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9420/2//COMMIT_MSG@15 PS2, Line 15: In addition there were two functions, NewFile() and : FileAllocateSpace() that always returned Status::OK(). I made them : void and removed the status checks from the call sites. > Any reason you included these changes? Seems like good cleanup to me. http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/io/disk-io-mgr.h@443 PS2, Line 443: faultInjectionToWrite_ nit: fault_injection_to_write_ http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/io/disk-io-mgr.h@443 PS2, Line 443: pair<string, int> It might be more readable if we define a struct here. http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/io/errno-to-error-status-converter.h File be/src/runtime/io/errno-to-error-status-converter.h: http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/io/errno-to-error-status-converter.h@28 PS2, Line 28: using std::unordered_map; Avoid "using" declarations in headers. http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9420/2/be/src/runtime/tmp-file-mgr.cc@315 PS2, Line 315: (*tmp_file)->AllocateSpace(scratch_range_bytes, file_offset); Thanks for the cleanup, this makes it simpler. -- To view, visit http://gerrit.cloudera.org:8080/9420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7b424209b1a5ef8dc7d04c5ba58788e91aad7 Gerrit-Change-Number: 9420 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Mar 2018 17:26:28 +0000 Gerrit-HasComments: Yes
